linux-kernel - Re: [PATCH 2/3] mm: fix possible incorrect return value of migrate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <op.whlc6hjn3l0zgt@mpn-glaptop>
Date:	Tue, 17 Jul 2012 15:02:31 +0200
From:	"Michal Nazarewicz" <mina86@...a86.com>
To:	"Michal Nazarewicz" <mina86@...n.pl>,
	"JoonSoo Kim" <js1304@...il.com>
Cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org, "Sasha Levin" <levinsasha928@...il.com>,
	"Christoph Lameter" <cl@...ux.com>
Subject: Re: [PATCH 2/3] mm: fix possible incorrect return value of
 migrate_pages() syscall

On Mon, 16 Jul 2012 19:59:18 +0200, JoonSoo Kim <js1304@...il.com> wrote:

> 2012/7/17 Michal Nazarewicz <mina86@...n.pl>:
>> Joonsoo Kim <js1304@...il.com> writes:
>>> do_migrate_pages() can return the number of pages not migrated.
>>> Because migrate_pages() syscall return this value directly,
>>> migrate_pages() syscall may return the number of pages not migrated.
>>> In fail case in migrate_pages() syscall, we should return error value.
>>> So change err to -EIO
>>>
>>> Additionally, Correct comment above do_migrate_pages()
>>>
>>> Signed-off-by: Joonsoo Kim <js1304@...il.com>
>>> Cc: Sasha Levin <levinsasha928@...il.com>
>>> Cc: Christoph Lameter <cl@...ux.com>
>>
>> Acked-by: Michal Nazarewicz <mina86@...a86.com>
>
> Thanks.
>
> When I resend with changing -EIO to -EBUSY,
> could I include "Acked-by: Michal Nazarewicz <mina86@...a86.com>"?

Sure thing.

-- 
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  Michał “mina86” Nazarewicz    (o o)
ooo +----<email/xmpp: mpn@...gle.com>--------------ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/