linux-kernel - Re: [PATCH v2] staging: sbe-2t3e3: Remove code that will never execute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 16 Jul 2012 19:11:06 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Marcos Paulo de Souza <marcos.souza.org@...il.com>
Cc:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	dan.carpenter@...cle.com, khc@...waw.pl
Subject: Re: [PATCH v2] staging: sbe-2t3e3: Remove code that will never
 execute

On Thu, Jul 12, 2012 at 11:27:49PM -0300, Marcos Paulo de Souza wrote:
> This patch removes all references of "if 0" blocks in the sbe-2t3e3 driver.
> 
> Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@...il.com>
> ---
>  drivers/staging/sbe-2t3e3/2t3e3.h    |    3 --
>  drivers/staging/sbe-2t3e3/cpld.c     |   15 ---------
>  drivers/staging/sbe-2t3e3/ctrl.c     |   19 +++--------
>  drivers/staging/sbe-2t3e3/dc.c       |   17 ----------
>  drivers/staging/sbe-2t3e3/exar7250.c |   40 +++--------------------
>  drivers/staging/sbe-2t3e3/exar7300.c |   17 ----------
>  drivers/staging/sbe-2t3e3/intr.c     |   60 ++--------------------------------
>  drivers/staging/sbe-2t3e3/io.c       |   21 ------------
>  8 files changed, 10 insertions(+), 182 deletions(-)
> 
> diff --git a/drivers/staging/sbe-2t3e3/2t3e3.h b/drivers/staging/sbe-2t3e3/2t3e3.h
> index fe9f086..383f2cf 100644
> --- a/drivers/staging/sbe-2t3e3/2t3e3.h
> +++ b/drivers/staging/sbe-2t3e3/2t3e3.h
> 
> Just fix the commit message fo sbr-2t3e3 to sbe-2t3e3.
> 
> @@ -801,9 +801,6 @@ u32 cpld_read(struct channel *sc, u32 reg);

Woah, what is that line in the middle of the patch here?  That causes
git to (rightfully) choke on the patch.

Please fix this and resend.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/