linux-kernel - Re: [PATCH RESEND 0/3] scsi: fix internal write cache issue on usb hdd.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120717154653.GF16283@kroah.com>
Date:	Tue, 17 Jul 2012 08:46:53 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	James Bottomley <James.Bottomley@...senPartnership.com>
Cc:	Namjae Jeon <linkinjeon@...il.com>, mdharm-usb@...-eyed-alien.net,
	stern@...land.harvard.edu, sshtylyov@...sta.com,
	bvanassche@....org, akpm@...ux-foundation.org,
	linux-usb@...r.kernel.org, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org, Namjae Jeon <namjae.jeon@...sung.com>
Subject: Re: [PATCH RESEND 0/3] scsi: fix internal write cache issue on usb
 hdd.

On Tue, Jul 17, 2012 at 08:19:14AM +0100, James Bottomley wrote:
> On Mon, 2012-07-16 at 16:48 -0700, Greg KH wrote:
> > On Sat, Jul 07, 2012 at 11:04:45PM -0400, Namjae Jeon wrote:
> > > From: Namjae Jeon <namjae.jeon@...sung.com>
> > > 
> > > The numbers of USB HDDs(All USB HDD I checked) does not respond
> > > correctly to scsi mode sense command for retrieving the write cache
> > > page status. Even though write cache is enabled by default, due to
> > > scsi driver assume that cache is not enabled which in turn might lead
> > > to loss of data since data still will be in cache.
> > > This result that all filesystems is not stable on USB HDD when the
> > > device is unplugged abruptly, even though these are having journaling
> > > feature. Our first trying is that scsi driver send ATA command
> > > (ATA Pass through, #85) to USB HDD after failure from normal routine to
> > > know write cache enable.
> > > We have known it is dangerous after testing several USB HDD. some of
> > > HDD is stalled by this command(A-DATA HDD). So we tried to make the
> > > patch James Bottomley's suggestion(usb quirk) on version 2 that add
> > > product ID and verdor ID of USB HDD to USB quirk list after checking
> > > write cache.
> > > All filesystem will be stable on USB HDD registered in quirk list.
> > > And it will be updated continuously.
> > 
> > Now applied to the usb-next branch.
> 
> It's been in scsi#misc for ten days with no problems.  Lets leave it
> there rather than create merge and rebase issues.

No need for rebasing.  It's already in my tree, so we can handle the
merge when this hits Linus's tree.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/