linux-kernel - Re: [PATCH 7/8] pstore/ram: Make tracing log versioned

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 17 Jul 2012 11:18:13 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Anton Vorontsov <anton.vorontsov@...aro.org>
Cc:	Kees Cook <keescook@...omium.org>,
	Colin Cross <ccross@...roid.com>,
	Tony Luck <tony.luck@...el.com>,
	Steven Rostedt <rostedt@...dmis.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...hat.com>, devel@...verdev.osuosl.org,
	linaro-kernel@...ts.linaro.org, Arnd Bergmann <arnd@...db.de>,
	patches@...aro.org, Marco Stornelli <marco.stornelli@...il.com>,
	Stephen Boyd <sboyd@...eaurora.org>,
	linux-kernel@...r.kernel.org, arve@...roid.com,
	Jesper Juhl <jj@...osbits.net>,
	John Stultz <john.stultz@...aro.org>,
	Shuah Khan <shuahkhan@...il.com>,
	Rebecca Schultz Zavin <rebecca@...roid.com>,
	WANG Cong <xiyou.wangcong@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	kernel-team@...roid.com, Thomas Meyer <thomas@...3r.de>
Subject: Re: [PATCH 7/8] pstore/ram: Make tracing log versioned

On Tue, Jul 17, 2012 at 11:09:18AM -0700, Anton Vorontsov wrote:
> On Tue, Jul 17, 2012 at 09:56:01AM -0700, Greg Kroah-Hartman wrote:
> [...]
> > That's nice, but it breaks the build on my system as linux_banner
> > somehow isn't enabled as part of the build?
> 
> I really don't see how you managed to disable it. :-)
> 
> init/version.c is built unconditionally, and it has
> 'const char linux_banner[]' unconditionally. Then ram.c includes
> kernel.h, which unconditionally (well, under #ifdef __KERNEL__)
> includes printk.h, which has 'extern const char linux_banner[];'
> prototype...
> 
> I'm still looking further, but can you please send your config
> file? And may be gcc version?

It failed in the linking stage, so perhaps it is because linux_banner is
not exported and you had module code looking for it?

.config is attached.

thanks,

greg k-h

Download attachment ".config" of type "application/x-config" (108584 bytes)