linux-kernel - Re: [PATCH] mfd: MAX77693: Fix bug of interrupt handlding for MAX77693 devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120717191451.GK4477@opensource.wolfsonmicro.com>
Date:	Tue, 17 Jul 2012 20:14:51 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Chanwoo Choi <cw00.choi@...sung.com>
Cc:	sameo@...ux.intel.com, myungjoo.ham@...sung.com,
	kyungmin.park@...sung.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: MAX77693: Fix bug of interrupt handlding for
 MAX77693 devices

On Tue, Jul 17, 2012 at 08:30:17AM +0900, Chanwoo Choi wrote:
> On 07/16/2012 10:36 PM, Mark Brown wrote:
> > On Mon, Jul 16, 2012 at 06:41:05PM +0900, Chanwoo Choi wrote:

> >> This patch fix bug related to interrupt handling for MAX77693 devices.
> >> - Unmask interrupt masking bit for charger/flash/muic to revolve
> >> that interrupt isn't happened when external connector is attached.

> > Shouldn't this be happening when the IRQ is requested?

> The interrupt isn't happened when external connector is attached
> because muic interrupt of MAX77693 is masked on INTSRC_MASK(
> Interrupt Source Mask) register. So, I should set zero to muic interrupt
> masking bit of INTSRC_MASK before requesting IRQ.

Right, but normally that unmasking happens in the unmask() callback of
the irq_chip which is called when the interrupt is requested.  Why isn't
that working here?

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)