linux-kernel - Re: [PATCH] ftrace: using pr_fmt for better printk output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1342499125.24525.11.camel@gandalf.stny.rr.com>
Date:	Tue, 17 Jul 2012 00:25:25 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Joe Perches <joe@...ches.com>
Cc:	Jovi Zhang <bookjovi@...il.com>,
	Frédéric Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ftrace: using pr_fmt for better printk output

On Mon, 2012-07-16 at 20:42 -0700, Joe Perches wrote:

> > diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
> []
> > @@ -13,6 +13,8 @@
> >   *  Copyright (C) 2004 William Lee Irwin III
> >   */
> > 
> > +#define pr_fmt(fmt) "ftrace: " fmt
> 
> #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

Wouldn't a nicer patch be to move this into a header file and then
remove all the defines throughout the kernel tree?

Also, what is KBUILD_MODNAME defined as for non-modules? As ftrace is
not a module.

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/