linux-kernel - Re: [PATCH V2 1/6] mfd: tps6586x:use devm managed resources

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5004ED3F.4080601@nvidia.com>
Date:	Tue, 17 Jul 2012 10:12:39 +0530
From:	Laxman Dewangan <ldewangan@...dia.com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
CC:	"grant.likely@...retlab.ca" <grant.likely@...retlab.ca>,
	"linus.walleij@...ricsson.com" <linus.walleij@...ricsson.com>,
	"sameo@...ux.intel.com" <sameo@...ux.intel.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Stephen Warren <swarren@...dia.com>
Subject: Re: [PATCH V2 1/6] mfd: tps6586x:use devm managed resources

On Tuesday 17 July 2012 01:31 AM, Mark Brown wrote:
> On Mon, Jul 16, 2012 at 12:21:45PM +0530, Laxman Dewangan wrote:
>
>> -	ret = request_threaded_irq(irq, NULL, tps6586x_irq, IRQF_ONESHOT,
>> -				   "tps6586x", tps6586x);
>> +	ret = devm_request_threaded_irq(tps6586x->dev, irq, NULL, tps6586x_irq,
>> +			IRQF_ONESHOT, "tps6586x", tps6586x);
> Are you sure this is safe - what guarantees that we can't get an
> interrupt while tearing the device down?

I think device_remove will get called before the managed resource get 
freed.
So do we need to call disable_irq() in remove() to avoid any interrupts?


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/