linux-kernel - Re: [PATCH 5/7 v2] dma: sh: use an integer slave ID to improve API compatibility

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1342581293.1726.66.camel@vkoul-udesk3>
Date:	Wed, 18 Jul 2012 08:44:53 +0530
From:	Vinod Koul <vinod.koul@...ux.intel.com>
To:	Guennadi Liakhovetski <g.liakhovetski@....de>
Cc:	Magnus Damm <magnus.damm@...il.com>, linux-sh@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/7 v2] dma: sh: use an integer slave ID to improve API
 compatibility

On Mon, 2012-07-16 at 14:47 +0200, Guennadi Liakhovetski wrote:
> > > Yes, that's right - these values have to be written to DMAC channel 
> > > configuration registers, so, we do not have to change anything, those 
> > > values can remain DMAC parameters and be passed to it directly from 
> > > platform data.
> > Can you get that in future fixes.
> 
> Sorry, what exactly would you like to have fixed here? Above I just 
> described how the driver already functions, what changes do you see 
> necessary? 
Why should client pass these two values. So the parameters which can be
calculated should be, and rest should dmacs platform data and not
clients.
And after the removal of the slave and adddr fields, you find that you
no longer need your specific slave structure and that can be elimnated
completely.

-- 
~Vinod

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/