linux-kernel - Re: [RESEND PATCH 1/2] mfd: add irq domain support for max8997 interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120718044656.GB10619@kroah.com>
Date:	Tue, 17 Jul 2012 21:46:56 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Chanwoo Choi <cw00.choi@...sung.com>
Cc:	thomas.abraham@...aro.org, broonie@...nsource.wolfsonmicro.com,
	grant.likely@...retlab.ca, sameo@...ux.intel.com,
	myungjoo.ham@...sung.com, kyungmin.park@...sung.com,
	linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH 1/2] mfd: add irq domain support for max8997
 interrupts

On Wed, Jul 18, 2012 at 10:48:04AM +0900, Chanwoo Choi wrote:
> On 07/18/2012 01:34 AM, Greg KH wrote:
> 
> > On Mon, Jul 02, 2012 at 09:02:55AM +0900, Chanwoo Choi wrote:
> >> From: Thomas Abraham <thomas.abraham@...aro.org>
> >>
> >> Add irq domain support for max8997 interrupts. The reverse mapping method
> >> used is linear mapping since the sub-drivers of max8997 such as regulator
> >> and charger drivers can use the max8997 irq_domain to get the linux irq
> >> number for max8997 interrupts. All uses of irq_base in platform data and
> >> max8997 driver private data are removed.
> >>
> >> Signed-off-by: Thomas Abraham <thomas.abraham@...aro.org>
> >> Acked-by: MyungJoo Ham <myungjoo.ham@...sung.com>
> >> Acked-by: Grant Likely <grant.likely@...retlab.ca>
> >> Acked-by: Samuel Ortiz <sameo@...ux.intel.com>
> >> 	[Fix two bug which set max8997->irq_domain and correct wrong parameter]
> >> Signed-off-by: Chanwoo Choi <cw00.choi@...sung.com>
> >> Signed-off-by: Kyungmin Park <kyungmin.park@...sung.com>
> >> ---
> >>  arch/arm/mach-exynos/mach-nuri.c    |    4 --
> >>  arch/arm/mach-exynos/mach-origen.c  |    1 -
> >>  drivers/mfd/Kconfig                 |    1 +
> >>  drivers/mfd/max8997-irq.c           |   62 +++++++++++++++++++++--------------
> >>  drivers/mfd/max8997.c               |    1 -
> >>  include/linux/mfd/max8997-private.h |    4 ++-
> >>  include/linux/mfd/max8997.h         |    1 -
> >>  7 files changed, 41 insertions(+), 33 deletions(-)
> > 
> > Once again, this patch breaks the build.
> > 
> > Please be more careful with your patches, and TEST THEM BEFORE SENDING
> > THEM OUT.
> > 
> 
> 
> I have posted patchset including below two patch. If only first patch is
> applied to build test, this patch breaks the build. The second patch fix
> that extcon-max8997 driver use irq_domain instead of irq_base field in
> 'struct max8997_dev'.
> 
> [PATCH v3 1/2] mfd: add irq domain support for max8997 interrupts
> [PATCH v3 2/2] Extcon: MAX8997: Add support irq domain for MAX8997 muic
> 
> Please apply second patch when test this patchset.

No.  You can not break the build at any point in the patch series
process, sorry.  Each patch must be stand-alone and correct.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/