linux-kernel - RE: [PATCH] regulator: tps65217: fix build error if REGULATOR is not enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <331ABD5ECB02734CA317220B2BBEABC13E9F8BD7@DBDE01.ent.ti.com>
Date:	Wed, 18 Jul 2012 09:55:57 +0000
From:	"AnilKumar, Chimata" <anilkumar@...com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
CC:	"rdunlap@...otime.net" <rdunlap@...otime.net>,
	"sfr@...b.auug.org.au" <sfr@...b.auug.org.au>,
	"sameo@...ux.intel.com" <sameo@...ux.intel.com>,
	"linux-next@...r.kernel.org" <linux-next@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>
Subject: RE: [PATCH] regulator: tps65217: fix build error if REGULATOR is
 not enabled

Mark,

On Wed, Jul 18, 2012 at 15:14:49, Mark Brown wrote:
> On Wed, Jul 18, 2012 at 12:11:03PM +0530, AnilKumar Ch wrote:
> > Fixes below build error if CONFIG_REGULATOR is not enabled.
> > 
> > drivers/built-in.o: In function `tps65217_probe':
> > tps65217.c:(.devinit.text+0x13e37): undefined reference to `of_regulator_match'
> 
> This isn't a patch to the regulator driver, this is a patch to the MFD.
> Normally this would be fixed by making the MFD driver not depend on the
> regulator API - why is the MFD driver using the regulator API?
> 

Regulators platform data is added to platform device in MFD driver, which we
need for regulator driver, of_regulator_match() is used to check the regulator
consumers if we pass DT data. If we do not enable CONFIG_REGULATOR then
of_regulator_match() is not exported, so we see this error.

Regards
AnilKumar

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/