linux-kernel - Re: [PATCH] rbtree: fix jffs2 build issue due to renamed __rb_parent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1342611635.25411.83.camel@shinybook.infradead.org>
Date:	Wed, 18 Jul 2012 12:40:35 +0100
From:	David Woodhouse <dwmw2@...radead.org>
To:	Michel Lespinasse <walken@...gle.com>
Cc:	aarcange@...hat.com, riel@...hat.com, peterz@...radead.org,
	daniel.santos@...ox.com, axboe@...nel.dk, ebiederm@...ssion.com,
	akpm@...ux-foundation.org, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, torvalds@...ux-foundation.org
Subject: Re: [PATCH] rbtree: fix jffs2 build issue due to renamed
 __rb_parent_color field

On Wed, 2012-07-18 at 04:31 -0700, Michel Lespinasse wrote:
> Fix this and add a comment explaining why this direct use is safe
> here.

Note that there was already a comment which was *intended* to have that
effect, right before the assignment:

        /* Colour doesn't matter now. Only the parent pointer. */

If you're going to make that comment redundant, you might as well remove
it. And you might as well say that the trees are being *destroyed*
(consumed) at this point, rather than just that there will be no further
insert or erase operations.

-- 
dwmw2

Download attachment "smime.p7s" of type "application/x-pkcs7-signature" (6171 bytes)