linux-kernel - Re: [PATCH 1/1 v2] classmate-laptop: Add support for Classmate V4 accelerometer.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5006BFEC.1010407@igalia.com>
Date:	Wed, 18 Jul 2012 15:53:48 +0200
From:	Miguel Gómez <magomez@...lia.com>
To:	Thadeu Lima de Souza Cascardo <cascardo@...oscopio.com>
CC:	don@...t.com.br, mjg@...hat.com,
	platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1 v2] classmate-laptop: Add support for Classmate V4
 accelerometer.

> On Fri, Jun 29, 2012 at 03:39:48PM +0200, Miguel Gómez wrote:
>> Classmate V4 laptop includes a new accelerometer that can't be handled by
>> previous driver. This patch adds a new driver to handle it.
>>
>> Signed-off-by: Miguel Gómez <magomez@...lia.com>
>
> Hi, Miguel.
>
> This seems OK to me. Thanks for this work. Do you have the other
> functionality of the driver working? I am interested to know if you have
> the function buttons working.

Hi Thadeu

I've been giving a look to the buttons code. Currently they are not 
working because the hardware id reported by the device (FNBT0000) is not 
the same as the one defined by the driver (FnBT0000), as you an one of 
my colleagues commented in this thread:

https://lkml.org/lkml/2011/6/21/341

I've replaced the id in the driver to FNBT0000 and it made the buttons 
work like a charm (enabling control of the backlight and LAN as well). 
To ensure compatibility with older versions of the kernel, a new id can 
be added (FNBT0000) besides the existent one (FnBT0000), and that works 
as well (as proposed in the thread).

It seems that this problem got a bit forgotten in the lists. Quoting 
yourself from the last email in the thread:

> I am copying the acpi list and Len Brown to see if they can tell us
> which one should be the right solution:
>
> 1) reverting the patch in acpica that puts all names in uppercase
> 2) using a case-insensitive match in acpi bus driver
> 3) using uppercase name in classmate-laptop driver

I think the easiest and less risky way to fix this is by adding a new 
hardware id (as proposed in the thread's patch), as it doesn't add any 
side effects (that the other solutions might add), and it doesn't break 
the behaviour of the old code.

What do you think?

Regards!

-- 
Miguel Gómez
Igalia - http://www.igalia.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/