linux-kernel - Re: [PATCH] led: use correct name for /sys/devices/virtual/leds/ entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 18 Jul 2012 19:01:08 +0200
From:	Lars-Peter Clausen <lars@...afoo.de>
To:	olaf@...fle.de
CC:	Bryan Wu <bryan.wu@...onical.com>,
	Richard Purdie <rpurdie@...ys.net>, linux-leds@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] led: use correct name for /sys/devices/virtual/leds/
 entries

On 07/18/2012 06:49 PM, olaf@...fle.de wrote:
> From: Olaf Hering <olaf@...fle.de>
> 
> Follow naming according to Documentation/leds/leds-class.txt:
> LED Device Naming
> Is currently of the form:
> "devicename:colour:function"
> 
> Reported during openSuSE 11.1 testing.
> https://bugzilla.novell.com/show_bug.cgi?&id=468350
> 
> Signed-off-by: Olaf Hering <olaf@...fle.de>
> 
> diff --git a/drivers/leds/ledtrig-default-on.c b/drivers/leds/ledtrig-default-on.c
> index a4ef54b..2efdd30 100644
> --- a/drivers/leds/ledtrig-default-on.c
> +++ b/drivers/leds/ledtrig-default-on.c
> @@ -23,7 +23,7 @@ static void defon_trig_activate(struct led_classdev *led_cdev)
>  }
>  
>  static struct led_trigger defon_led_trigger = {
> -	.name     = "default-on",
> +	.name     = "default::on",
>  	.activate = defon_trig_activate,
>  };
>  

That's a LED trigger, not a LED. So the LED naming convention doesn't apply
here and it does not even make sense to try to apply it. Also the patch
breaks all users of the default-on trigger.

- Lars
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/