linux-kernel - Re: linux-next: Tree for July 17 (mfd: AB3100 - ab3100_probe: undefined reference to `rand_initialize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+icZUWzS==NVNstc3RUfKe-=4UVtAza36LuFRuAp-zeX=5WyA@mail.gmail.com>
Date:	Wed, 18 Jul 2012 19:54:46 +0200
From:	Sedat Dilek <sedat.dilek@...il.com>
To:	Linus Walleij <linus.walleij@...aro.org>
Cc:	"Theodore Ts'o" <tytso@....edu>, linux-next@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>,
	Linus Walleij <linus.walleij@...ricsson.com>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	linux-arm-kernel@...ts.infradead.org,
	Stephen Rothwell <sfr@...b.auug.org.au>
Subject: Re: linux-next: Tree for July 17 (mfd: AB3100 - ab3100_probe:
 undefined reference to `rand_initialize_irq')

On Tue, Jul 17, 2012 at 8:40 PM, Linus Walleij <linus.walleij@...aro.org> wrote:
> On Tue, Jul 17, 2012 at 12:39 PM, Sedat Dilek <sedat.dilek@...il.com> wrote:
>> On Tue, Jul 17, 2012 at 12:21 PM, Sedat Dilek <sedat.dilek@...il.com> wrote:
>>> ...looks like AB3100 is the *only* driver still using rand_initialize_irq()...
>>>
>>> drivers/mfd/ab3100-core.c:939:  rand_initialize_irq(client->irq);
>>>
>>> ...but why has random.h still this...?
>>>
>>> include/linux/random.h:51:extern void rand_initialize_irq(int irq);
>>>
>>> Just thinking "loud"...
>>>
>>> - Sedat -
>>
>> Is this attached patch OK, Ted?
>
> You're just deleting a line from the AB3100 driver, so I guess you're
> regressing the system since that IRQ will no longer contribute
> to the entropy pool?
>
> How do we simultaneously make sure that this IRQ is still
> contributing to the entropy?
>

For the sake of completeness:
* Ted explained in his answer in [1].
* Just FYI: [2] has these changes merged into the original commit.

- Sedat -

[1] http://marc.info/?l=linux-next&m=134256445707799&w=2
[2] http://git.kernel.org/?p=linux/kernel/git/tytso/random.git;a=commitdiff;h=627574db8b21c51217c683909458500916e64963

> Yours,
> Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/