linux-kernel - Re: [PATCH 2/2] regmap-irq: support different type of irq register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120719091520.GJ4495@opensource.wolfsonmicro.com>
Date:	Thu, 19 Jul 2012 10:15:21 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	"Kim, Milo" <Milo.Kim@...com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] regmap-irq: support different type of irq register

On Thu, Jul 19, 2012 at 09:04:44AM +0000, Kim, Milo wrote:

> + * @irq_type:    Interrupt register type. masked or enabled
>   */
>  struct regmap_irq_chip {
>  	const char *name;
> @@ -304,6 +311,8 @@ struct regmap_irq_chip {
>  
>  	const struct regmap_irq *irqs;
>  	int num_irqs;
> +
> +	enum regirq_type irq_type;

This naming is very unclear - it's not about the interrupt itself, it's
about the mask for the interrupt.  This would more normally be covered
by marking the masks as being inverted rather than something like this.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)