linux-kernel - Re: [PATCH 01/90] staging: comedi: comedidev.h: introduce comedi_to_pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5007D1E0.4050503@mev.co.uk>
Date:	Thu, 19 Jul 2012 10:22:40 +0100
From:	Ian Abbott <abbotti@....co.uk>
To:	H Hartley Sweeten <hartleys@...ionengravers.com>
CC:	Linux Kernel <linux-kernel@...r.kernel.org>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	Ian Abbott <ian.abbott@....co.uk>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
Subject: Re: [PATCH 01/90] staging: comedi: comedidev.h: introduce comedi_to_pci_dev()
 helper

On 2012-07-19 02:24, H Hartley Sweeten wrote:
> Introduce a wrapper for to_pci_dev() to allow the comedi pci drivers
> to store the pci_dev pointer in the comedi_device hw_dev variable and
> retrieve it easily.
>
> Signed-off-by: H Hartley Sweeten <hsweeten@...ionengravers.com>
> Cc: Ian Abbott <abbotti@....co.uk>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> ---
>   drivers/staging/comedi/comedidev.h | 5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/drivers/staging/comedi/comedidev.h b/drivers/staging/comedi/comedidev.h
> index de8c99c..620222d 100644
> --- a/drivers/staging/comedi/comedidev.h
> +++ b/drivers/staging/comedi/comedidev.h
> @@ -446,6 +446,11 @@ static inline void comedi_set_hw_dev(struct comedi_device *dev,
>   	}
>   }
>
> +static inline struct pci_dev *comedi_to_pci_dev(struct comedi_device *dev)
> +{
> +	return to_pci_dev(dev->hw_dev);
> +}
> +

That needs to be something like:

	return dev->hw_dev ? to_pci_dev(dev->hw_dev) : NULL;

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/