linux-kernel - Re: [PATCH 1/1 v3] Honor state disabling in the cpuidle ladder governor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5007F1F3.9090706@osadl.org>
Date:	Thu, 19 Jul 2012 13:39:31 +0200
From:	Carsten Emde <C.Emde@...dl.org>
To:	Deepthi Dharwar <deepthi@...ux.vnet.ibm.com>
CC:	Len Brown <len.brown@...el.com>, Kevin Hilman <khilman@...com>,
	Thomas Gleixner <tglx@...utronix.de>,
	LKML <linux-kernel@...r.kernel.org>,
	Linux PM mailing list <linux-pm@...r.kernel.org>
Subject: Re: [PATCH 1/1 v3] Honor state disabling in the cpuidle ladder governor
 - with sanitizer

Deepthi,

>>> [..]
>>>> I could implement a sanitize mechanism of the ladder governor that
>>>> takes care the "disable" variables of all deeper states are set to 1,
>>>> if a state is disabled, and those of all lighter states are set to 0,
>>>> if a state is enabled. Do you wish me to do that?
>>> No, I dont think thats necessary, current code suffices it.
>>> The disable flag is knob we are giving to the user . So may be just
>>> document  the  intended use of disable flag working
>>> alongside design of ladder governor.
>> It's not necessary - but maybe better. Here comes v3 with a sanitizer.
>> Is this too ugly?
> The v2, with the documentation in place seems sufficient.
> Yup, this adds unnecessary fields which are not much use
> coz the same can be achieved with just disable flag check.
ok, let's take v2.

> Also, any reason why the patch is being sent as an attachment ?
> Sending patches as an attachment is not a recommended practice.
Sorry.

	-Carsten.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/