linux-kernel - Re: [PATCH] kvm: fix race with level interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1342699591.3229.46.camel@ul30vt>
Date:	Thu, 19 Jul 2012 06:06:31 -0600
From:	Alex Williamson <alex.williamson@...hat.com>
To:	"Michael S. Tsirkin" <mst@...hat.com>
Cc:	Avi Kivity <avi@...hat.com>, Marcelo Tosatti <mtosatti@...hat.com>,
	gleb@...hat.com, kvm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kvm: fix race with level interrupts

On Thu, 2012-07-19 at 12:15 +0300, Michael S. Tsirkin wrote:
> On Wed, Jul 18, 2012 at 05:22:42PM -0600, Alex Williamson wrote:
> > I hate reviewing code
> > > > where I have to differentiate 'l' vs '1'.
> > > 
> > > l is an illegal variable name?  Switch to a different font.
> > 
> > WTF
> 
> Really, you should use a font where these differ. I currently use
> Monospace but there are many other good fonts.  If you don't bugs sneak
> in.
> 
> int x = 11;
> and
> int x = 1l;
> 
> Should look very different.

Don't be an asshole, my dog could tell the difference between those
side-by-side.  That's not what you posted.  I use monospace as well and
find it offensive that you suggest someone change fonts to review your
code.  Clearly, any time spent trying to identify a single character in
isolation is not well spent.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/