linux-kernel - Re: [PATCH 88/90] staging: comedi: rtd520: store the pci_dev in the comedi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50080083.6050204@mev.co.uk>
Date:	Thu, 19 Jul 2012 13:41:39 +0100
From:	Ian Abbott <abbotti@....co.uk>
To:	H Hartley Sweeten <hartleys@...ionengravers.com>
CC:	Linux Kernel <linux-kernel@...r.kernel.org>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	Ian Abbott <ian.abbott@....co.uk>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
Subject: Re: [PATCH 88/90] staging: comedi: rtd520: store the pci_dev in the
 comedi_device

On 2012-07-19 03:05, H Hartley Sweeten wrote:
> Use the hw_dev pointer in the comedi_device struct to hold the
> pci_dev instead of carrying it in the private data.

My reply to patch 86 has a knock-on effect for this patch...

>   	/* Get the physical address from PCI config */
> -	dev->iobase = pci_resource_start(devpriv->pci_dev, LAS0_PCIINDEX);
> -	physLas1 = pci_resource_start(devpriv->pci_dev, LAS1_PCIINDEX);
> -	physLcfg = pci_resource_start(devpriv->pci_dev, LCFG_PCIINDEX);
> +	dev->iobase = pci_resource_start(pcidev, LAS0_PCIINDEX);
> +	physLas1 = pci_resource_start(pcidev, LAS1_PCIINDEX);
> +	physLcfg = pci_resource_start(pcidev, LCFG_PCIINDEX);

...in the use of dev->iobase to hold a PCI memory address.

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/