linux-kernel - Re: [PATCH v2] mm/memcg: use exist interface to get css from memcg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 19 Jul 2012 05:55:15 -0700 (PDT)
From:	Hugh Dickins <hughd@...gle.com>
To:	Kamezawa Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
cc:	Michal Hocko <mhocko@...e.cz>,
	Wanpeng Li <liwanp@...ux.vnet.ibm.com>, linux-mm@...ck.org,
	Johannes Weiner <hannes@...xchg.org>, cgroups@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Gavin Shan <shangw@...ux.vnet.ibm.com>,
	Bob Liu <lliubbo@...il.com>
Subject: Re: [PATCH v2] mm/memcg: use exist interface to get css from memcg

On Thu, 19 Jul 2012, Kamezawa Hiroyuki wrote:
> (2012/07/19 18:29), Michal Hocko wrote:
> > On Wed 18-07-12 19:08:54, Wanpeng Li wrote:
> > > use exist interface mem_cgroup_css instead of &mem->css.
> > 
> > This interface has been added to enable mem->css outside of
> > mm/memcontrol.c (where we define struct mem_cgroup). There is one user
> > left (hwpoison_filter_task) after recent clean ups.
> > 
> > I think we shouldn't spread the usage inside the mm/memcontrol.c. The
> > compiler inlines the function for all callers added by this patch but I
> > wouldn't rely on it. It is also unfortunate that we cannot convert all
> > dereferences (e.g. const mem_cgroup).
> > Moreover it doesn't add any additional type safety. So I would vote for
> > not taking the patch but if others like it I will not block it.
> > 
> 
> Agreed.

Very strongly agreed: I found it hard to be as polite as you have been.

Hugh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/