linux-kernel - Re: [PATCH] PCDP: use early_ioremap/early

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1342711674.13917.106.camel@lyra>
Date:	Thu, 19 Jul 2012 09:27:54 -0600
From:	Khalid Aziz <khalid.aziz@...com>
To:	Greg Pearson <greg.pearson@...com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PCDP: use early_ioremap/early_iounmap to access pcdp
 table

On Wed, 2012-07-18 at 16:19 -0600, Greg Pearson wrote:
> Signed-off-by: Greg Pearson <greg.pearson@...com>
> ---
>  drivers/firmware/pcdp.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/firmware/pcdp.c b/drivers/firmware/pcdp.c
> index 51e0e2d..a330492 100644
> --- a/drivers/firmware/pcdp.c
> +++ b/drivers/firmware/pcdp.c
> @@ -95,7 +95,7 @@ efi_setup_pcdp_console(char *cmdline)
>  	if (efi.hcdp == EFI_INVALID_TABLE_ADDR)
>  		return -ENODEV;
>  
> -	pcdp = ioremap(efi.hcdp, 4096);
> +	pcdp = early_ioremap(efi.hcdp, 4096);
>  	printk(KERN_INFO "PCDP: v%d at 0x%lx\n", pcdp->rev, efi.hcdp);
>  
>  	if (strstr(cmdline, "console=hcdp")) {
> @@ -131,6 +131,6 @@ efi_setup_pcdp_console(char *cmdline)
>  	}
>  
>  out:
> -	iounmap(pcdp);
> +	early_iounmap(pcdp, 4096);
>  	return rc;
>  }

This looks good to me.

Acked-by: Khalid Aziz <khalid.aziz@...com>

-- 
Khalid Aziz <khalid.aziz@...com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/