linux-kernel - Re: [PATCH v2] Btrfs: allow mount -o remount,compress=no

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKcLGm-UYXYM2nP=iW1o5gdFYh4mi_XGFPGKfd054xvvGfAc=w@mail.gmail.com>
Date:	Thu, 19 Jul 2012 14:31:27 -0500
From:	Mitch Harder <mitch.harder@...ayonlinux.org>
To:	dave@...os.cz, Mitch Harder <mitch.harder@...ayonlinux.org>,
	Arnd Hannemann <arnd@...dnet.de>, chris.mason@...ionio.com,
	linux-btrfs@...r.kernel.org, linux-kernel@...r.kernel.org,
	ierdnah@...il.com
Subject: Re: [PATCH v2] Btrfs: allow mount -o remount,compress=no

On Wed, Jul 18, 2012 at 8:28 PM, David Sterba <dave@...os.cz> wrote:
> On Fri, Jul 13, 2012 at 10:19:14AM -0500, Mitch Harder wrote:
>> I was testing the lz4(hc) patches, and I found the the compression
>> INCOMPAT flags are not being updated using the method in this patch.
>>
>> The compression INCOMPAT flags are generally checked and updated in
>> the open_ctree() function.
>>
>> But, on remount, open_ctree() is not called.
>
> This currently happens with lzo as well, right?
>

Yes, this will happen with lzo as implemented in the patch at the head
of this thread.

>
> My preference is to let remount succeed and set the incompat bit,
> possibly with a KERN_INFO message to syslog in case the bit is yet
> unseen by the volume.
>

Great.

I've put together a patch that does just that, and I've been testing
it to make sure it works as intended.

I'll finish it up and send it to the list tomorrow.

This patch will only address the lzo INCOMPAT from the remount
capabilities provided by the patch at the head of the thread.

A similar modification will be needed for lz4 patches that allow for remount.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/