linux-kernel - Re: [PATCH 06/17] xen-blkfront: remove IRQF_SAMPLE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120719194446.GA17097@phenom.dumpdata.com>
Date:	Thu, 19 Jul 2012 15:44:46 -0400
From:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
To:	"Theodore Ts'o" <tytso@....edu>
Cc:	Linux Kernel Developers List <linux-kernel@...r.kernel.org>,
	Jeremy Fitzhardinge <jeremy@...p.org>
Subject: Re: [PATCH 06/17] xen-blkfront: remove IRQF_SAMPLE_RANDOM which is
 now a no-op

On Tue, Jul 17, 2012 at 05:32:25PM -0400, Theodore Ts'o wrote:
> With the changes in the random tree, IRQF_SAMPLE_RANDOM is now a
> no-op; interrupt randomness is now collected unconditionally in a very
> low-overhead fashion; see commit 775f4b297b.  The IRQF_SAMPLE_RANDOM
> flag was scheduled to be removed in 2009 on the
> feature-removal-schedule, so this patch is preparation for the final
> removal of this flag.
> 
> Signed-off-by: "Theodore Ts'o" <tytso@....edu>
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>

Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
> Cc: Jeremy Fitzhardinge <jeremy@...p.org>
> ---
>  drivers/block/xen-blkfront.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
> index 60eed4b..8f7a071 100644
> --- a/drivers/block/xen-blkfront.c
> +++ b/drivers/block/xen-blkfront.c
> @@ -854,9 +854,8 @@ static int setup_blkring(struct xenbus_device *dev,
>  	if (err)
>  		goto fail;
>  
> -	err = bind_evtchn_to_irqhandler(info->evtchn,
> -					blkif_interrupt,
> -					IRQF_SAMPLE_RANDOM, "blkif", info);
> +	err = bind_evtchn_to_irqhandler(info->evtchn, blkif_interrupt, 0,
> +					"blkif", info);
>  	if (err <= 0) {
>  		xenbus_dev_fatal(dev, err,
>  				 "bind_evtchn_to_irqhandler failed");
> -- 
> 1.7.11.1.108.gb129051
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/