linux-kernel - Re: [PATCH] kernel: acct.c: spaces required around that '<'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120719225550.GX31729@ZenIV.linux.org.uk>
Date:	Thu, 19 Jul 2012 23:55:50 +0100
From:	Al Viro <viro@...IV.linux.org.uk>
To:	jan.bannister@...il.com
Cc:	schwidefsky@...ibm.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kernel: acct.c:  spaces required around that '<'

On Thu, Jul 19, 2012 at 10:10:27PM +0100, jan.bannister@...il.com wrote:
> From: Jan Bannister <jan.bannister@...il.com>
> 
> Fixed a coding style issue

NAK, because I'm sick and tired of the pompous commit messages.  I'm fine
with adding those spaces.  However, I _do_ have a lot against the commit
messages like that.  "Required"?  By whom?  Holy checkpatch.pl?  "Coding
style issue" - completely uninformative; there all kinds of those.

FWIW, my prefernce would be something along the lines of "whitespace
tidy-up in <function or file name>".  At least that says what happens
in commit and where is it happening...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/