linux-kernel - Re: Boot breaks in -next from LEGACY to LINEAR conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120720094248.GM4495@opensource.wolfsonmicro.com>
Date:	Fri, 20 Jul 2012 10:42:49 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Grant Likely <grant.likely@...retlab.ca>
Cc:	Paul Mundt <lethal@...ux-sh.org>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Rob Herring <rob.herring@...xeda.com>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	Kukjin Kim <kgene.kim@...sung.com>
Subject: Re: Boot breaks in -next from LEGACY to LINEAR conversion

On Thu, Jul 19, 2012 at 10:30:11PM -0600, Grant Likely wrote:

> Okay, I've got a theory about what the issue is now. The .map()
> callback is failing (returning non-zero) for one of the hwirqs. The
> new code is stricter about associations, and actually unwinds the
> associations if one of them fails. The old legacy code simply called
> all the .map() hooks blindly without any error checking. Can you send
> me the kernel log after backing out those changes.

Looks like the error checking is the issue.  Always knew that was a bad
idea :)  I've just sent a patch to improve the diagnostics here which
might help a bit, though I realise now with some of my debug I need to
send a v2 :/ .

On my system there's only one mapping failed, but it's for one of the
VIC mappings which is rather unfortunate.  The error is there because
the VIC is returning -ENOTSUPP to skip invalid IRQs which doesn't
immediately seem like an awful thing to do for generic code like this.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)