linux-kernel - Re: [patch] tty: handle NULL parameters in free_tty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120720104831.47cb4237@pyramind.ukuu.org.uk>
Date:	Fri, 20 Jul 2012 10:48:31 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [patch] tty: handle NULL parameters in free_tty_struct()

On Fri, 20 Jul 2012 10:06:34 +0300
Dan Carpenter <dan.carpenter@...cle.com> wrote:

> We sometimes pass NULL pointers to free_tty_struct().  One example where
> it can happen is in the error handling code in pty_common_install().
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Acked-by: Alan Cox <alan@...ux.intel.com>

We probably shouldn't be passing NULLs there but making
free_tty_struct(NULL) a no-op matches the kfree and other behaviours and
is robust.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/