linux-kernel - Re: [PATCH] PM / Sleep: Print name of wakeup source that aborts suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <201207201155.24730.rjw@sisk.pl>
Date:	Fri, 20 Jul 2012 11:55:24 +0200
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Todd Poynor <toddpoynor@...gle.com>
Cc:	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
	arve@...roid.com
Subject: Re: [PATCH] PM / Sleep: Print name of wakeup source that aborts suspend

On Friday, July 20, 2012, Todd Poynor wrote:
> On Wed, Jul 18, 2012 at 09:47:34PM +0200, Rafael J. Wysocki wrote:
> > On Wednesday, July 18, 2012, Todd Poynor wrote:
> ...
> > > +{
> > > +	struct wakeup_source *ws;
> > > +	int active = 0;
> > > +	struct wakeup_source *last_activity_ws = NULL;
> > > +
> > > +	rcu_read_lock();
> > > +	list_for_each_entry_rcu(ws, &wakeup_sources, entry) {
> > > +		if (ws->active) {
> > > +			pr_info("active wakeup source: %s\n", ws->name);
> > > +			active = 1;
> > 
> > Can we do a break here?  Or do we want to get all of them?
> 
> I haven't seen more than 3 activated during suspend entry at a time, but
> could just list one.  I haven't made that change yet but will if it's
> preferred.

That depend on what your needs are.  For debugging purposes it probably is
better to print them all.

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/