linux-kernel - Re: [RFC][PATCH] hwmon: add support for Sensirion C1 sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEYbzYuDJLarBULPz1ooSiLhtFsL-YZ-DAxwFW76LnmQ67n5Qw@mail.gmail.com>
Date:	Fri, 20 Jul 2012 17:35:10 +0200
From:	Johannes Winkelmann <johannes.winkelmann@...il.com>
To:	Oliver Neukum <oneukum@...e.de>
Cc:	linux-kernel@...r.kernel.org, lm-sensors@...sensors.org,
	Jean Delvare <khali@...ux-fr.org>,
	Guenter Roeck <linux@...ck-us.net>,
	Johannes Winkelmann <johannes.winkelmann@...sirion.com>
Subject: Re: [RFC][PATCH] hwmon: add support for Sensirion C1 sensor

On Fri, Jul 20, 2012 at 5:14 PM, Oliver Neukum <oneukum@...e.de> wrote:
> On Friday 20 July 2012 17:13:51 Johannes Winkelmann wrote:
>> On Fri, Jul 20, 2012 at 4:03 PM, Oliver Neukum <oneukum@...e.de> wrote:
>
>> > We have dedicated macros for conversion of endianness.
>>
>> Like this:
>>               val = swab16p((__le16 *)buf);
>>               data->temperature = ((21875 * val) >> 13) - 45000;
>>               val = swab16p((__le16 *)(buf+2));
>>               data->humidity = ((15000 * val) >> 13) - 10000;
>
> I was thinking of be16_to_cpu()

Ok, fixed locally; I'll collect some more feedback and will resubmit v2

Thanks,
Johannes
-- 
Johannes Winkelmann
jw@...s.ch
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/