linux-kernel - Re: [PATCH] checkpatch: Add checks for do {} while (0) macro misuses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1342799397.21447.35.camel@joe2Laptop>
Date:	Fri, 20 Jul 2012 08:49:57 -0700
From:	Joe Perches <joe@...ches.com>
To:	Betty Dall <betty.dall@...com>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Andy Whitcroft <apw@...onical.com>
Subject: Re: [PATCH] checkpatch: Add checks for do {} while (0) macro misuses

On Fri, 2012-07-20 at 14:40 +0000, Betty Dall wrote:

> I reviewed this and tested it out on the qib.h file we were looking at yesterday 
> and it worked well. I was worried about a nested do {} while(0), because it will 
> match with the first while. Here is a test case:
> #define qib_devinfo(pcidev, fmt, ...) \
>         do { \
>                 do { \
>                         dev_info(&(pcidev)->dev, fmt, ##__VA_ARGS__); \
>                 } while (0); \
>         } while (0)
> 
> Checkpatch.pl didn't complain about that one. Granted, it is a contrived test 
> case. Your change will catch the real problems.

Hi Betty.

Wow, you're thorough.  Thanks for testing.

I don't mind that it doesn't work in all cases.
I suppose this would fail for loops too.

checkpatch is a pretty limited tool as it depends on
the code being compilable and doesn't really understand
c syntax.  It is just a convenience tool and lots of
its logic is incomplete and some of its output can be
happily ignored.

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/