[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <1342820197.5434.54.camel@lorien2>
Date: Fri, 20 Jul 2012 15:36:37 -0600
From: Shuah Khan <shuah.khan@...com>
To: David Miller <davem@...emloft.net>
Cc: mcarlson@...adcom.com, bhutchings@...arflare.com,
eric.dumazet@...il.com, mchan@...adcom.com, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH RFT] net: Fix Neptune ethernet driver to check dma
mapping error
On Fri, 2012-07-20 at 14:30 -0700, David Miller wrote:
> From: Shuah Khan <shuah.khan@...com>
> Date: Fri, 20 Jul 2012 15:27:59 -0600
>
> > Request for testing, since I don't have the hardware to test.
>
> This is not how you post a patch.
>
> > --------------------------------------------------------------------
>
> When you put those "---..." there, GIT is going to eliminate everything
> afterwards from the commit mesage when I apply this. Yet afterwards
> is what your commit message actually is.
>
> You therefore should do things the other way around, provide the commit
> message text, then the "---..." line, then your comments you don't want
> in the final commit message.
Thanks. I had it reversed in my head for some reason. Maybe not enough
coffee :) Will resend the patch now.
-- Shuah
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists