linux-kernel - Re: [Question] perf header: Why the HEADER_EVENT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 21 Jul 2012 19:16:11 +0200
From:	Stephane Eranian <eranian@...gle.com>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [Question] perf header: Why the HEADER_EVENT_DESC is needed?

On Sat, Jul 21, 2012 at 1:11 PM, Namhyung Kim <namhyung@...nel.org> wrote:
> Hi Stephane,
>
> I wonder why we need to save the event descriptions in the feature area
> of file header. Since the perf_event_attr, its ids and the event name
> are already saved in the header, it seems a duplicate work to do that.
> For printing the information, we might reuse those info or evlist
> directly IMHO.
>
> Am I missing something?

Unfortunately, I think you are.

There event names are not saved in header.c except indirectly by write_cmdline.
But more importantly, event_desc makes it possible to connect an event name as
passed on the cmdline with the corresponding attr struct.

Furthermore, it is also present in pipe mode, with the patch I posted
months ago.

Finally, you cannot arbitrarily remove features like this. We do have
tools that do
rely on the presence of EVENT_DESC.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/