linux-kernel - Re: [PATCH] mmc: omap_hsmmc: ensure probe returns error upon resource failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87k3xw3dhk.fsf@octavius.laptop.org>
Date:	Sat, 21 Jul 2012 19:23:35 -0400
From:	Chris Ball <cjb@...top.org>
To:	"S\, Venkatraman" <svenkatr@...com>
Cc:	Kevin Hilman <khilman@...com>, linux-mmc@...r.kernel.org,
	linux-omap@...r.kernel.org, Balaji T K <balajitk@...com>,
	Rajendra Nayak <rnayak@...com>,
	Adrian Hunter <adrian.hunter@...el.com>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mmc: omap_hsmmc: ensure probe returns error upon resource failure

Hi,

On Thu, Jul 12 2012, S, Venkatraman wrote:
> On Wed, Jul 11, 2012 at 5:10 AM, Kevin Hilman <khilman@...com> wrote:
>> If platform_get_resource_by_name() fails, driver probe is aborted an
>> should return an error so the driver is not bound to the device.
>>
>> However, in the current error path of platform_get_resource_by_name(),
>> probe returns zero since the return value (ret) is not properly set.
>> With a zero return value, the driver core assumes probe was successful
>> and will bind the driver to the device.
>>
>> Fix this by ensuring that probe returns an error code in this failure
>> path.
>>
>> Signed-off-by: Kevin Hilman <khilman@...com>
>
> Good catch.
> Acked-by: Venkatraman S <svenkatr@...com>

Thanks, pushed to mmc-next for 3.6.

- Chris.
-- 
Chris Ball   <cjb@...top.org>   <http://printf.net/>
One Laptop Per Child
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/