linux-kernel - Re: [PATCH v2] leds: add new lp8788 led driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120722181956.GA4557@opensource.wolfsonmicro.com>
Date:	Sun, 22 Jul 2012 19:19:56 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Bryan Wu <bryan.wu@...onical.com>
Cc:	shuahkhan@...il.com, "Kim, Milo" <Milo.Kim@...com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] leds: add new lp8788 led driver

On Sat, Jul 21, 2012 at 02:48:49AM +0800, Bryan Wu wrote:

> Actually cancel_work_sync() is quite similar to flush_work_sync()
> here. For the timer thing, in fact it is NULL when cancel_work_sync()
> call __cancel_work_timer().

> And Mark, do you have any advice about the flush_work_sync() and
> cancel_work_sync(). I saw you use flush in the
> drivers/leds/leds-wm8350.c.

If the work is flushed then the state that userspace thought was set
when the driver is removed will actually be set before the driver is
removed.  This is fairly minor but might be useful.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)