linux-kernel - Re: [PATCH 1/2] Staging: slicoss: Clean up tabs vs spaces in slic.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1207231047390.701@swampdragon.chaosbits.net>
Date:	Mon, 23 Jul 2012 10:48:49 +0200 (CEST)
From:	Jesper Juhl <jj@...osbits.net>
To:	Dan Carpenter <dan.carpenter@...cle.com>
cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org,
	Christopher Harrer <charrer@...critech.com>,
	linux-kernel@...r.kernel.org, Lior Dotan <liodot@...il.com>
Subject: Re: [PATCH 1/2] Staging: slicoss: Clean up tabs vs spaces in
 slic.h

On Mon, 23 Jul 2012, Dan Carpenter wrote:

> On Sun, Jul 22, 2012 at 10:57:09PM +0200, Jesper Juhl wrote:
> > Make it match CodingStyle a bit better, tab/space wise.
> > 
> > Signed-off-by: Jesper Juhl <jj@...osbits.net>
> > ---
> >  drivers/staging/slicoss/slic.h | 751 ++++++++++++++++++++---------------------
> >  1 file changed, 374 insertions(+), 377 deletions(-)
> > 
> > diff --git a/drivers/staging/slicoss/slic.h b/drivers/staging/slicoss/slic.h
> > index ebdcc6f..0deb670 100644
> > --- a/drivers/staging/slicoss/slic.h
> > +++ b/drivers/staging/slicoss/slic.h
> > @@ -42,61 +42,62 @@
> >  #define __SLIC_DRIVER_H__
> >  
> >  /* firmware stuff */
> > -#define OASIS_UCODE_VERS_STRING	"1.2"
> > -#define OASIS_UCODE_VERS_DATE  	"2006/03/27 15:10:37"
> > -#define OASIS_UCODE_HOSTIF_ID  	3
> > +#define OASIS_UCODE_VERS_STRING "1.2"
> > +#define OASIS_UCODE_VERS_DATE "2006/03/27 15:10:37"
> > +#define OASIS_UCODE_HOSTIF_ID 3
> 
> No.  The original was far better.
> 
> Looking through the rest of the patch, some of these changes are ok,
> and some are nonsense.
> 
Ok, thank you for taking a look. I'll give this patch (as well as 2/2) a 
new look tonight and re-spin them and hopefully do better the second time 
around :-)

-- 
Jesper Juhl <jj@...osbits.net>       http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/