linux-kernel - Re: [PATCH] gpiolib: Use seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120723121222.GA27187@avionic-0098.mockup.avionic-design.de>
Date:	Mon, 23 Jul 2012 14:12:22 +0200
From:	Thierry Reding <thierry.reding@...onic-design.de>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	linux-kernel@...r.kernel.org,
	Linus Walleij <linus.walleij@...ricsson.com>,
	Grant Likely <grant.likely@...retlab.ca>
Subject: Re: [PATCH] gpiolib: Use seq_file's iterator interface

On Sat, May 12, 2012 at 12:56:14PM +0000, Arnd Bergmann wrote:
> On Thursday 12 April 2012, Thierry Reding wrote:
> > When dumping a collection of items via seq_file, it is recommended to
> > use the iterator interface. For the gpiolib debugfs interface this can
> > be done to dump each GPIO chip in turn.
> > 
> > Note that for gpiolib this is a little cumbersome because it does not
> > provide a list of registered GPIO chips and the only way to iterate is
> > over each GPIO individually. Once a chip is found, the number of GPIOs
> > it provides can be skipped as a small optimization.
> > 
> > This patch was requested by Arnd Bergmann here:
> > 
> >         http://article.gmane.org/gmane.linux.ports.tegra/3535
> > 
> > Signed-off-by: Thierry Reding <thierry.reding@...onic-design.de>
> > Cc: Linus Walleij <linus.walleij@...ricsson.com>
> > Cc: Grant Likely <grant.likely@...retlab.ca>
> > Cc: Arnd Bergmann <arnd@...db.de>
> > Cc: linux-kernel@...r.kernel.org
> 
> Reviewed-by: Arnd Bergmann <arnd@...db.de>

Grant, Linus,

Is this good to go?

Thierry

Content of type "application/pgp-signature" skipped