linux-kernel - Re: [PATCH 2/2 v3] USB: dwc3-exynos: Add vbus setup function to the exynos dwc3 glue layer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20120723152407.GC9020@arwen.pp.htv.fi>
Date:	Mon, 23 Jul 2012 18:24:09 +0300
From:	Felipe Balbi <balbi@...com>
To:	Vivek Gautam <gautamvivek1987@...il.com>
Cc:	balbi@...com, Vivek Gautam <gautam.vivek@...sung.com>,
	stern@...land.harvard.edu, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org, devicetree-discuss@...ts.ozlabs.org,
	l.majewski@...sung.com, a.kesavan@...sung.com,
	prashanth.g@...sung.com, kmpark@...radead.org, joshi@...sung.com,
	olofj@...gle.com, thomas.abraham@...aro.org, sshtylyov@...sta.com,
	av.tikhomirov@...sung.com
Subject: Re: [PATCH 2/2 v3] USB: dwc3-exynos: Add vbus setup function to the
 exynos dwc3 glue layer

Hi,

On Tue, Jul 24, 2012 at 12:09:47AM +0900, Vivek Gautam wrote:
<snip>
> > > @@ -58,6 +81,8 @@ static int __devinit dwc3_exynos_probe(struct
> > platform_device *pdev)
> > >       if (!pdev->dev.coherent_dma_mask)
> > >               pdev->dev.coherent_dma_mask = DMA_BIT_MASK(32);
> > >
> > > +     dwc3_setup_vbus_gpio(pdev);
> >
> > I think this should be handled by the gpio-vbus transceiver. No ?
> >
> > I can understand that we can use gpio-vbus transceiver. But i have one
> confusion here.
> We have ehci as well as this dwc3 which need gpio to be setup to
> control vbus. So do we have two instances of this gpio-vbus driver to
> facilitate both ehci and dwc3, because both may be on different gpio
> lines.

Sure... one for dwc3 and one for ehci.

> Moreover, the gpio line right now is parsed from the DT node of the
> device, so while assigning the 'gpio_vbus' field in
> 'gpio_vbus_mach_info', how do we provide that. Please suggest.

gpio-vbus doesn't have support for DT today, just add it ;-)

> One more suggestion please. Now that we are moving to DT we should be
> making changes for gpio-vbus transceiver also for device tree support.

yes, it needs support for DT before you can use it then.

cheers

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)