linux-kernel - RE: [PATCH 2/2] x86/mce: Add quirk for instruction recovery on Sandy Bridge processors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3908561D78D1C84285E8C5FCA982C28F1936F3DB@ORSMSX104.amr.corp.intel.com>
Date:	Mon, 23 Jul 2012 16:11:03 +0000
From:	"Luck, Tony" <tony.luck@...el.com>
To:	Borislav Petkov <bp@...64.org>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...e.hu>,
	Chen Gong <gong.chen@...ux.intel.com>,
	"Huang, Ying" <ying.huang@...el.com>,
	Hidetoshi Seto <seto.hidetoshi@...fujitsu.com>
Subject: RE: [PATCH 2/2] x86/mce: Add quirk for instruction recovery on
 Sandy Bridge processors

> Other things which could probably be used are alternatives or jump
> labels but one if-test is simply not worth the complexity.

It might be if this were a super-hot path. But if you are getting so many machine
checks that you can see the effect of one extra "if" ... then you are hurting in
so many other ways!

> Oh well, enough games.

Thanks for the review.

-Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/