linux-kernel - Re: [PATCH] [CPUFREQ] conservative: Initialise the cpu field of the this_dbs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <201207232055.26506.rjw@sisk.pl>
Date:	Mon, 23 Jul 2012 20:55:26 +0200
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Amit Daniel Kachhap <amit.daniel@...sung.com>
Cc:	cpufreq@...r.kernel.org, linux-pm@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [CPUFREQ] conservative: Initialise the cpu field of the this_dbs_info

On Monday, July 23, 2012, Amit Daniel Kachhap wrote:
> On 23 July 2012 15:53, Rafael J. Wysocki <rjw@...k.pl> wrote:
> 
> > On Monday, July 23, 2012, Amit Daniel Kachhap wrote:
> > > This patch initialises the cpu field of this_dbs_info structure. This
> > > change is similar to existing ondemand governor.
> >
> > Why do you think the change is needed?
> >
> > Rafael
> >
> 
> I agree that this field is not used anywhere currently but I was trying to
> perform some experiments and then this un-initialised field caused issues
> so i thought of fixing this up.

So perhaps please write in the changelog that this is to keep governors
consistent with each other or something like this.  Without explanation it
looks pointless.

Thanks,
Rafael


> > > Signed-off-by: Amit Daniel Kachhap <amit.daniel@...sung.com>
> > > ---
> > >  drivers/cpufreq/cpufreq_conservative.c |    1 +
> > >  1 files changed, 1 insertions(+), 0 deletions(-)
> > >
> > > diff --git a/drivers/cpufreq/cpufreq_conservative.c
> > b/drivers/cpufreq/cpufreq_conservative.c
> > > index 235a340..a1563d7 100644
> > > --- a/drivers/cpufreq/cpufreq_conservative.c
> > > +++ b/drivers/cpufreq/cpufreq_conservative.c
> > > @@ -504,6 +504,7 @@ static int cpufreq_governor_dbs(struct
> > cpufreq_policy *policy,
> > >                               j_dbs_info->prev_cpu_nice =
> > >
> > kcpustat_cpu(j).cpustat[CPUTIME_NICE];
> > >               }
> > > +             this_dbs_info->cpu = cpu;
> > >               this_dbs_info->down_skip = 0;
> > >               this_dbs_info->requested_freq = policy->cur;
> > >
> > >
> >
> >
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/