linux-kernel - Re: [Xen-devel] Was: Re: [GIT PULL] timer changes for v3.6, Is: Regression introduced by 1e75fa8be9fb61e1af46b5b3b176347a4c958ca1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120723195144.GA3454@phenom.dumpdata.com>
Date:	Mon, 23 Jul 2012 15:51:44 -0400
From:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
To:	John Stultz <john.stultz@...aro.org>
Cc:	xen-devel@...ts.xensource.com,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [Xen-devel] Was: Re: [GIT PULL] timer changes for v3.6, Is:
 Regression introduced by 1e75fa8be9fb61e1af46b5b3b176347a4c958ca1

> Does the following resolve it? If not I have a debug patch I'll send
> you to try to chase this down.

Yup. That makes it boot without crash and without any WARN_ON.  I am going
to run it overnight on some other machines but so far it looks to have
fixed the regression. So please attach:

Reported-and-Tested-by: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>

> 
> thanks
> -john
> 
> 
> diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c
> index f045cc5..cf364db 100644
> --- a/kernel/time/timekeeping.c
> +++ b/kernel/time/timekeeping.c
> @@ -108,13 +108,13 @@ static struct timespec tk_xtime(struct timekeeper *tk)
>  static void tk_set_xtime(struct timekeeper *tk, const struct timespec *ts)
>  {
>  	tk->xtime_sec = ts->tv_sec;
> -	tk->xtime_nsec = ts->tv_nsec << tk->shift;
> +	tk->xtime_nsec = (u64)ts->tv_nsec << tk->shift;
>  }
>  static void tk_xtime_add(struct timekeeper *tk, const struct timespec *ts)
>  {
>  	tk->xtime_sec += ts->tv_sec;
> -	tk->xtime_nsec += ts->tv_nsec << tk->shift;
> +	tk->xtime_nsec += (u64)ts->tv_nsec << tk->shift;
>  }
>  /**
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@...ts.xen.org
> http://lists.xen.org/xen-devel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/