linux-kernel - Re: [Bcache v14 PATCH] fix compiler error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120723211212.GA29052@google.com>
Date:	Mon, 23 Jul 2012 14:12:12 -0700
From:	Kent Overstreet <koverstreet@...gle.com>
To:	Daniel Wisehart <daniel.wisehart@...dian.com>
Cc:	linux-kernel@...r.kernel.org, dm-devel@...hat.com
Subject: Re: [Bcache v14 PATCH] fix compiler error

On Thu, Jul 19, 2012 at 04:53:26PM -0400, Daniel Wisehart wrote:
> Hello Kent, 
> 
> This patch keeps gcc 4.7.0 happy.  The static function dump_bset() could be moved, but that would have made a bigger patch.  :-)

Thanks! dump_bset() does need to be moved so it's available if DEBUG or
EDEBUG are on, but thanks for pointing it out :)

> 
> Thanks,
> Daniel
> 
> 
> 
> diff --git a/drivers/md/bcache/debug.c b/drivers/md/bcache/debug.c
> index 3c9c24d..4dc0ba5 100644
> --- a/drivers/md/bcache/debug.c
> +++ b/drivers/md/bcache/debug.c
> @@ -83,6 +83,8 @@ struct keyprint_hack bch_pbtree(const struct btree *b)
>  
>  #ifdef CONFIG_BCACHE_DEBUG
>  
> +static void dump_bset(struct btree *b, struct bset *i);
> +
>  void bch_btree_verify(struct btree *b, struct bset *new)
>  {
>         struct btree *v = b->c->verify_data;
> 
> 
> This communication is restricted - please see http://www.eladian.com for further information.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/