linux-kernel - Re: [PATCH v3] ext4: fix hole punch failure when depth is greater than 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120723003440.GG9958@thunk.org>
Date:	Sun, 22 Jul 2012 20:34:40 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Ashish Sangwan <ashishsangwan2@...il.com>
Cc:	linux-kernel@...r.kernel.org, linux-ext4@...r.kernel.org,
	lczerner@...hat.com, Ashish Sangwan <ashish.sangwan2@...il.com>,
	Namjae Jeon <linkinjeon@...il.com>
Subject: Re: [PATCH v3] ext4: fix hole punch failure when depth is greater
 than 0

On Tue, Jul 10, 2012 at 09:56:10PM +0530, Ashish Sangwan wrote:
> Whether to continue removing extents or not is decided by the return value
> of function ext4_ext_more_to_rm() which checks 2 conditions:
> a) if there are no more indexes to process.
> b) if the number of entries are decreased in the header of "depth -1".
> 
> In case of hole punch, if the last block to be removed is not part of the
> last extent index than this index will not be deleted, hence the number of
> valid entries in the extent header of "depth - 1" will remain as it is and
> ext4_ext_more_to_rm will return 0 although the required blocks are not
> yet removed.
> 
> This patch fixes the above mentioned problem as instead of removing the
> extents from the end of file, it starts removing the blocks from the
> particular extent from which removing blocks is actually required and
> continue backward until done.
> 
> Signed-off-by: Ashish Sangwan <ashish.sangwan2@...il.com>
> Signed-off-by: Namjae Jeon <linkinjeon@...il.com>
> Reviewed-by: Lukas Czerner <lczerner@...hat.com>

Applied, with a cc: to stable@...nel.org since it is a bug fix.

Thanks for submitting this patch!

	      	       			       	  - Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/