linux-kernel - Re: [PATCH] add blockconsole version 1.1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120724154218.GB13753@x1.osrc.amd.com>
Date:	Tue, 24 Jul 2012 17:42:19 +0200
From:	Borislav Petkov <bp@...en8.de>
To:	Jörn Engel <joern@...fs.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, Jeff Moyer <jmoyer@...hat.com>,
	Steve Hodgson <steve@...estorage.com>
Subject: Re: [PATCH] add blockconsole version 1.1

On Mon, Jul 23, 2012 at 04:04:59PM -0400, Jörn Engel wrote:
> On Wed, 18 July 2012 23:45:21 +0200, Borislav Petkov wrote:
> > 
> > Something like the above, just slap it at the beginning of
> > Documentation/block/blockconsole.txt for impatient people like me and
> > that's it :-).
> 
> And below is an updated patch with your changes folded in.  I did a
> few minor tweaks, so there is every possibility I may have messed it
> up.

Ok, everything seems to build and boot fine, logging works too.

Just a minor nuisance: I have this in the log:

...
[   10.498422] console [bcon0] enabled
[   10.499899] blockconsole: now logging to /dev/sdc at 1
[   10.594791] usb 5-2: new full-speed USB device number 3 using ohci_hcd
                                                                                                                                
[   12.665911] xhci_hcd 0000:00:10.0: xHCI Host Controller
[   12.668469] xhci_hcd 0000:00:10.0: new USB bus registered, assigned bus number 6
...

which doesn't have the empty line with a bunch of '\s' chars:

...
[   10.498422] console [bcon0] enabled
[   10.499899] blockconsole: now logging to /dev/sdc at 1
[   10.594791] usb 5-2: new full-speed USB device number 3 using ohci_hcd
[   12.665911] xhci_hcd 0000:00:10.0: xHCI Host Controller
[   12.668469] xhci_hcd 0000:00:10.0: new USB bus registered, assigned bus number 6
...

Do you know per-chance why that happens? I have a couple more lines like
that further in the log file which bcon_tail generated.

Thanks.

-- 
Regards/Gruss,
Boris.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/