linux-kernel - Re: [PATCH] add blockconsole version 1.1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120724145334.GB24954@logfs.org>
Date:	Tue, 24 Jul 2012 10:53:35 -0400
From:	Jörn Engel <joern@...fs.org>
To:	Borislav Petkov <bp@...en8.de>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, Jeff Moyer <jmoyer@...hat.com>,
	Steve Hodgson <steve@...estorage.com>
Subject: Re: [PATCH] add blockconsole version 1.1

On Tue, 24 July 2012 17:42:19 +0200, Borislav Petkov wrote:
> 
> Just a minor nuisance: I have this in the log:
> 
> ...
> [   10.498422] console [bcon0] enabled
> [   10.499899] blockconsole: now logging to /dev/sdc at 1
> [   10.594791] usb 5-2: new full-speed USB device number 3 using ohci_hcd
>                                                                                                                                 
> [   12.665911] xhci_hcd 0000:00:10.0: xHCI Host Controller
> [   12.668469] xhci_hcd 0000:00:10.0: new USB bus registered, assigned bus number 6
> ...
> 
> which doesn't have the empty line with a bunch of '\s' chars:
> 
> ...
> [   10.498422] console [bcon0] enabled
> [   10.499899] blockconsole: now logging to /dev/sdc at 1
> [   10.594791] usb 5-2: new full-speed USB device number 3 using ohci_hcd
> [   12.665911] xhci_hcd 0000:00:10.0: xHCI Host Controller
> [   12.668469] xhci_hcd 0000:00:10.0: new USB bus registered, assigned bus number 6
> ...
> 
> Do you know per-chance why that happens? I have a couple more lines like
> that further in the log file which bcon_tail generated.

If there is no logging for a second, blockconsole will flush the
current sector.  So however much of it is empty will be filled with
spaces and a newline at the end.  Result are those empty lines.

The advantage should be better robustness, in particular when dealing
with cheap flash devices.  Disadvantage is the wasted real estate on
your monitor - although sometimes I have found it nice to have syntax
highlighting (in a way) for pauses in the logging.

Jörn

--
It does not require a majority to prevail, but rather an irate,
tireless minority keen to set brush fires in people's minds.
-- Samuel Adams
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/