linux-kernel - Re: [PATCH v2] posix_types.h: make __NFDBITS compatible with glibc definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120724190302.GE10534@zod.bos.redhat.com>
Date:	Tue, 24 Jul 2012 15:03:03 -0400
From:	Josh Boyer <jwboyer@...hat.com>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>, law@...hat.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] posix_types.h: make __NFDBITS compatible with glibc
 definition

On Tue, Jul 24, 2012 at 11:46:25AM -0700, Linus Torvalds wrote:
> On Tue, Jul 24, 2012 at 11:32 AM, Josh Boyer <jwboyer@...hat.com> wrote:
> > Recent glibc made a change to suppress sign-conversion warnings from FD_SET
> > (glibc commit ceb9e56b3d1).  That patch solved the particular error it was
> > aiming to, however applications that #include <linux/types.h> after
> > including <sys/select.h> can now hit a build failure if -Werror=sign-compare
> > and -D_FORTIFY_SOURCE=2 is passed to gcc.  This can be seen when building
> > this trivial application against a recent enough glibc:
> 
> Looking more at this, I now hate it for *another* reason.
> 
> Making __NFDBITS be a signed value turns __FDELT() and __FDMASK() into
> potentially pure and utter crap. Doing signed divisions (or modulus)
> is a disaster - suddenly it's not just a bit shift any more.
> 
> Guys, the glibc people really seem to not have thought their change
> through. Or maybe they fixed their __FDELT/__FDMASK at the same time?

Jeff can probably answer this better than I can, so likely best to wait
for him.

FWIW, the definitions of __FD_ELT/__FD_MASK in glibc are:

#define __FD_ELT(d)     ((d) / __NFDBITS)
#define __FD_MASK(d)    ((__fd_mask) 1 << ((d) % __NFDBITS))

where __fd_mask is 'typdef long int'.

__NFDBITS was changed to int type with glibc commit eb0b6cb6e in 2009,
and __FDELT/__FDMASK were basically renamed with glibc commit
e529793b508 in 2011.

josh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/