linux-kernel - Re: [PATCH] posix_types.h: make _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <500EF541.50009@redhat.com>
Date:	Tue, 24 Jul 2012 13:19:29 -0600
From:	Jeff Law <law@...hat.com>
To:	Josh Boyer <jwboyer@...hat.com>
CC:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] posix_types.h: make __NFDBITS match glibc definition

On 07/24/12 12:24, Josh Boyer wrote:
> On Tue, Jul 24, 2012 at 11:20:11AM -0700, Linus Torvalds wrote:
>> On Tue, Jul 24, 2012 at 11:12 AM, Josh Boyer <jwboyer@...hat.com> wrote:
>>>
>>> +#define __NFDBITS      (8 * (int) sizeof(long int))
>>
>> I don't know if the type change is needed, but who the hell uses "long int"?
>
> Not strictly, no.  I believe in my brief tests, just the int cast was
> sufficient.  I can respin if you'd like.  I probably need to anyway to
> CC stable on this.
All that's strictly necessary is that cast to (int).  That avoids the 
problem.

Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/