linux-kernel - Re: [PATCH v2] posix_types.h: make __NFDBITS compatible with glibc definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 24 Jul 2012 12:43:14 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Jeff Law <law@...hat.com>
Cc:	Josh Boyer <jwboyer@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] posix_types.h: make __NFDBITS compatible with glibc definition

On Tue, Jul 24, 2012 at 12:26 PM, Jeff Law <law@...hat.com> wrote:
>
> Right.  Josh's change is necessary to prevent warnings from folks
> (incorrectly) using posix_types.h instead of select.h after the change in
> that BZ was made.  That's why I originally stated that, arguably,
> posix_types.h really should go away or just use the definitions provided by
> glibc.

I think we should likely keep __FD_SETSIZE, since that really is a
valid kernel value (that the kernel actually uses). The rest looks
*entirely* bogus.

And the reason I emphasize the "entirely" is literally that the kernel
headers don't even define the full __FD_SET/CLR/ISSET() functionality.
We never use those inside the kernel itself, and we don't even
*define* them. So it's not even useful to some non-glibc user, afaik,
because the kernel only exports those really *odd* internal names. It
really looks entirely like some remnant from long long long ago when
the kernel headers actually used to have the whole functionality, but
then the functionality was removed, and now only some building blocks
are left - but not enough to really do anything useful with.

Just enough to be annoying.

                  Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/