linux-kernel - Re: [PATCH] extcon: extcon_gpio: Replace gpio_request_one by devm_gpio_request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <500F8FD9.1080601@samsung.com>
Date:	Wed, 25 Jul 2012 15:19:05 +0900
From:	Chanwoo Choi <cw00.choi@...sung.com>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	MyungJoo Ham <myungjoo.ham@...sung.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Mike Lockwood <lockwood@...roid.com>
Subject: Re: [PATCH] extcon: extcon_gpio: Replace gpio_request_one by
 devm_gpio_request_one

On 07/24/2012 10:26 AM, Axel Lin wrote:

> commit 01eaf24 "extcon: Convert extcon_gpio to devm_gpio_request_one"
> missed the replacement for devm_gpio_request_one. fix it.
> 
> Signed-off-by: Axel Lin <axel.lin@...il.com>
> ---
>  drivers/extcon/extcon_gpio.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/extcon/extcon_gpio.c b/drivers/extcon/extcon_gpio.c
> index fe3db45..3cc152e 100644
> --- a/drivers/extcon/extcon_gpio.c
> +++ b/drivers/extcon/extcon_gpio.c
> @@ -107,7 +107,8 @@ static int __devinit gpio_extcon_probe(struct platform_device *pdev)
>  	if (ret < 0)
>  		return ret;
>  
> -	ret = gpio_request_one(extcon_data->gpio, GPIOF_DIR_IN, pdev->name);
> +	ret = devm_gpio_request_one(&pdev->dev, extcon_data->gpio, GPIOF_DIR_IN,
> +				    pdev->name);
>  	if (ret < 0)
>  		goto err;
>  

It is right.

Signed-off-by: Chanwoo Choi <cw00.choi@...sung.com>

Thank you,
Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/