linux-kernel - Re: [PATCH] extcon: arizona: Implement button detection support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120725111105.GI3099@opensource.wolfsonmicro.com>
Date:	Wed, 25 Jul 2012 12:11:06 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Chanwoo Choi <cw00.choi@...sung.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	MyungJoo Ham <myungjoo.ham@...sung.com>,
	patches@...nsource.wolfsonmicro.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] extcon: arizona: Implement button detection support

On Wed, Jul 25, 2012 at 03:09:56PM +0900, Chanwoo Choi wrote:
> On 07/21/2012 01:07 AM, Mark Brown wrote:

Please delete irrelevant context from your replies, it makes it much
easier to find what you're saying.

> Why do you should report released event to all of buttons? I think that
> you should only
> report released event to previous pressed button. If user press two
> button on the headset
> at the same time and then user release only one button with pressed
> another button, extcon-arizona driver have to report released event to
> previous pressed button except for still pressed another button.

The input API already supresses duplicate reports, they won't be
propagated to userspace, so there's no point in duplicating the work
to remember what buttons are pressed in individual drivers.  Userspace
will only see events reported that refect changes in state.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)