linux-kernel - Re: [PATCH 00/13] UAPI header file split

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <12201.1343215232@warthog.procyon.org.uk>
Date:	Wed, 25 Jul 2012 12:20:32 +0100
From:	David Howells <dhowells@...hat.com>
To:	Michael Kerrisk <mtk.manpages@...il.com>
Cc:	dhowells@...hat.com, linux-arch@...r.kernel.org,
	linux-kernel@...r.kernel.org, arnd@...db.de, tglx@...utronix.de,
	mingo@...nel.org, davej@...hat.com
Subject: Re: [PATCH 00/13] UAPI header file split

Michael Kerrisk <mtk.manpages@...il.com> wrote:

> >> 2. EMPTY UAPI HEADERS
> >>
> >> Some of the resulting uapi header files are empty:
> >> ...
> >> I imagine this should be reasonably easy to fix.
> >
> > Fix how?  The Kbuild files say these headers must exist in UAPI space, but
> > the __KERNEL__ guards therein don't define any content for them in UAPI.
> 
> I'm not sure of the answer here. It certainly seems odd to have a
> bunch of new empty header files in the kernel tree, which is why I
> commented on it. Without digging much deeper, I've no idea whether the
> Kbuild files can be (automatically?) modified not to require these
> empty files.

You can't get rid of the empty header files completely.  They're exported to
userspace and so userspace may require their presence.

I could put a guard in there just so they're not empty, I suppose.

> So, a manual fix may be in order?

Or just apply the removal regexp to each line before I write the UAPI header
out.  I'll have a play with it later.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/