linux-kernel - RE: [PATCH v2 0/4] ACPI: hotplug messages improvement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1343230282.3010.387.camel@misato.fc.hp.com>
Date:	Wed, 25 Jul 2012 09:31:22 -0600
From:	Toshi Kani <toshi.kani@...com>
To:	"Pandarathil, Vijaymohan R" <vijaymohan.pandarathil@...com>
Cc:	"lenb@...nel.org" <lenb@...nel.org>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"joe@...ches.com" <joe@...ches.com>,
	"bhelgaas@...gle.com" <bhelgaas@...gle.com>,
	"isimatu.yasuaki@...fujitsu.com" <isimatu.yasuaki@...fujitsu.com>,
	"liuj97@...il.com" <liuj97@...il.com>,
	"srivatsa.bhat@...ux.vnet.ibm.com" <srivatsa.bhat@...ux.vnet.ibm.com>,
	"prarit@...hat.com" <prarit@...hat.com>,
	"imammedo@...hat.com" <imammedo@...hat.com>
Subject: RE: [PATCH v2 0/4] ACPI: hotplug messages improvement

On Wed, 2012-07-25 at 06:15 +0000, Pandarathil, Vijaymohan R wrote:
> Hi Toshi,
> 
> Tested your patches on a KVM setup. Since all your acpi_pr* macros
> are in the error path, I didn't see an easy way to trigger them.
> Instead added an acpi_pr_err() message in the success path and tested
> out vcpu addition/deletion sequence. No regressions seen in the
> functional tests and the ACPI err message comes out on the console
> and message buffer with a valid ACPI device path.
> 
> Vijay
> 
> Tested-by: Vijay Mohan Pandarathil<vijaymohan.pandarathil@...com>

Hi Vijay,

Thanks for the testing!  It sounds good to me and that's how I tested as
well, i.e. copied all messages to the normal path.  I will add your
Tested-by to patch 1/4 and 2/4.

-Toshi


> -----Original Message-----
> From: Kani, Toshimitsu 
> Sent: Friday, July 20, 2012 9:54 AM
> To: lenb@...nel.org; linux-acpi@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org; joe@...ches.com; bhelgaas@...gle.com; isimatu.yasuaki@...fujitsu.com; liuj97@...il.com; srivatsa.bhat@...ux.vnet.ibm.com; prarit@...hat.com; imammedo@...hat.com; Pandarathil, Vijaymohan R; Kani, Toshimitsu
> Subject: [PATCH v2 0/4] ACPI: hotplug messages improvement
> 
> This patchset improves logging messages for ACPI CPU, Memory, and
> Container hotplug notify handlers.  The patchset introduces a set of
> new macro interfaces, acpi_pr_<level>(), and updates the notify
> handlers to use them.  acpi_pr_<level>() appends "ACPI" prefix and
> ACPI object path to the messages.  This improves diagnostics in
> hotplug operations since it identifies an object that caused an
> issue in a log file.
> 
> v2:
>  - Set buffer.pointer to NULL in acpi_printk().
>  - Added acpi_pr_debug().
> 
> ---
> This patchset applies on top of the patch below.
> 
> [PATCH] ACPI: Add ACPI CPU hot-remove support
> http://marc.info/?l=linux-acpi&m=134098193327362&w=2
> 
> ---
> Toshi Kani (4):
>  ACPI: Add acpi_pr_<level>() interfaces
>  ACPI: Update CPU hotplug messages
>  ACPI: Update Memory hotplug messages
>  ACPI: Update Container hotplug messages
> 
> ---
>  drivers/acpi/acpi_memhotplug.c  |   24 ++++++++++++------------
>  drivers/acpi/container.c        |    6 +++---
>  drivers/acpi/processor_driver.c |   36 +++++++++++++++++++++---------------
>  drivers/acpi/utils.c            |   34 ++++++++++++++++++++++++++++++++++
>  include/acpi/acpi_bus.h         |   20 ++++++++++++++++++++
>  5 files changed, 90 insertions(+), 30 deletions(-)


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/